megaproxy/Petbot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent future database orphaning by reverting to INSERT OR IGNORE

Browse source 
🛡️ Prevention Fix:
- Reverted pet_species loading back to INSERT OR IGNORE
- Reverted locations loading back to INSERT OR IGNORE
- Reverted location_spawns loading back to INSERT OR IGNORE
- Kept achievements as INSERT OR REPLACE (they need updates)

🔧 Why This Fix:
- INSERT OR REPLACE deletes existing records and creates new ones with new IDs
- This orphans any player data that references the old IDs
- INSERT OR IGNORE preserves existing records and their IDs
- New pets/locations can still be added, but existing ones won't be deleted

✅ Result:
- Current players: Already fixed with manual database repair
- Future players: Will use existing stable IDs
- Data updates: Achievements can still be updated, reference data is stable
- No more orphaned foreign key references possible

This ensures the database ID orphaning issue can never happen again.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
megaproxy 2025-07-14 12:13:20 +01:00
parent 821c6f570c
commit 86b5fa998c
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/game_engine.py
View file

@ -36,7 +36,7 @@ class GameEngine:
async with aiosqlite.connect(self.database.db_path) as db: async with aiosqlite.connect(self.database.db_path) as db:
for species in species_data: for species in species_data:
await db.execute(""" await db.execute("""
INSERT OR REPLACE INTO pet_species INSERT OR IGNORE INTO pet_species
(name, type1, type2, base_hp, base_attack, base_defense, (name, type1, type2, base_hp, base_attack, base_defense,
base_speed, evolution_level, rarity) base_speed, evolution_level, rarity)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)
@ -103,7 +103,7 @@ class GameEngine:
async with aiosqlite.connect(self.database.db_path) as db: async with aiosqlite.connect(self.database.db_path) as db:
for species in default_species: for species in default_species:
await db.execute(""" await db.execute("""
INSERT OR REPLACE INTO pet_species INSERT OR IGNORE INTO pet_species
(name, type1, type2, base_hp, base_attack, base_defense, base_speed, rarity) (name, type1, type2, base_hp, base_attack, base_defense, base_speed, rarity)
VALUES (?, ?, ?, ?, ?, ?, ?, ?) VALUES (?, ?, ?, ?, ?, ?, ?, ?)
""", ( """, (
@ -123,7 +123,7 @@ class GameEngine:
async with aiosqlite.connect(self.database.db_path) as db: async with aiosqlite.connect(self.database.db_path) as db:
for location in locations_data: for location in locations_data:
await db.execute(""" await db.execute("""
INSERT OR REPLACE INTO locations (name, description, level_min, level_max) INSERT OR IGNORE INTO locations (name, description, level_min, level_max)
VALUES (?, ?, ?, ?) VALUES (?, ?, ?, ?)
""", (location["name"], location["description"], """, (location["name"], location["description"],
location["level_min"], location["level_max"])) location["level_min"], location["level_max"]))
@ -142,7 +142,7 @@ class GameEngine:
if species_id: if species_id:
await db.execute(""" await db.execute("""
INSERT OR REPLACE INTO location_spawns INSERT OR IGNORE INTO location_spawns
(location_id, species_id, spawn_rate, min_level, max_level) (location_id, species_id, spawn_rate, min_level, max_level)
VALUES (?, ?, ?, ?, ?) VALUES (?, ?, ?, ?, ?)
""", (location_id, species_id[0], spawn["spawn_rate"], """, (location_id, species_id[0], spawn["spawn_rate"],